Differential D9508

Allow entire dashboards to be copied
ClosedPublic
Actions

Authored by epriestley on Jun 13 2014, 1:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 5:55 PM

	Unknown Object (File)
	Sun, Nov 24, 2:13 PM

	Unknown Object (File)
	Thu, Nov 21, 2:39 AM

	Unknown Object (File)
	Sat, Nov 16, 11:44 PM

	Unknown Object (File)
	Oct 24 2024, 3:55 AM

	Unknown Object (File)
	Oct 21 2024, 11:37 PM

	Unknown Object (File)
	Oct 16 2024, 6:33 AM

	Unknown Object (File)
	Oct 16 2024, 3:40 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP18757e43de2b: Allow entire dashboards to be copied

Summary

Further improve UX for dealing with policy rules on dashboards:

When in the "Manage" view of a dashboard you can not edit:
- Don't show the panel management controls.
- Show a notice that the board isn't editable, recommending you make a copy instead.
Add a "Copy Dashboard" action to create a copy which you can edit.

Test Plan

Copied some dashboards. See screenshots.

Diff Detail

Repository

Branch

dash9

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1045
Build 1045: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22784.Jun 13 2014, 1:34 AM

epriestley retitled this revision from to Allow entire dashboards to be copied.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 13 2014, 1:34 AM

Harbormaster completed remote builds in B1045: Diff 22784.Jun 13 2014, 1:35 AM

Managing a dashboard you can't edit:

Screen_Shot_2014-06-12_at_6.35.03_PM.png (1×1 px, 235 KB)

Create a copy:

Screen_Shot_2014-06-12_at_6.35.08_PM.png (1×1 px, 215 KB)

Here is your copy:

Screen_Shot_2014-06-12_at_6.35.24_PM.png (1×1 px, 138 KB)

After adjustments, you have a version you can customize:

Screen_Shot_2014-06-12_at_6.35.19_PM.png (1×1 px, 240 KB)

chad accepted this revision.Jun 13 2014, 3:21 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2014, 3:21 AM

Closed by commit rP18757e43de2b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

dashboard/

application/

PhabricatorApplicationDashboard.php

1 line

controller/

PhabricatorDashboardCopyController.php

68 lines

PhabricatorDashboardManageController.php

25 lines

storage/

PhabricatorDashboard.php

10 lines

PhabricatorDashboardPanel.php

5 lines

Diff 22784

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/application/PhabricatorApplicationDashboard.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardCopyController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...