Differential D9508

Allow entire dashboards to be copied
ClosedPublic
Actions

Authored by epriestley on Jun 13 2014, 1:34 AM.

Tags

None

Referenced Files

	F13397741: D9508.diff
	Thu, Jul 4, 6:34 AM

	F13375502: D9508.diff
	Sat, Jun 29, 1:43 AM

	F13359467: D9508.diff
	Tue, Jun 25, 9:41 AM

	F13344015: D9508.diff
	Fri, Jun 21, 6:33 AM

	F13330490: D9508.diff
	Mon, Jun 17, 3:44 AM

	F13319843: D9508.diff
	Thu, Jun 13, 3:31 PM

	F13319172: D9508.diff
	Thu, Jun 13, 12:14 PM

	F13302855: D9508.id22788.diff
	Sat, Jun 8, 5:55 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP18757e43de2b: Allow entire dashboards to be copied

Summary

Further improve UX for dealing with policy rules on dashboards:

When in the "Manage" view of a dashboard you can not edit:
- Don't show the panel management controls.
- Show a notice that the board isn't editable, recommending you make a copy instead.
Add a "Copy Dashboard" action to create a copy which you can edit.

Test Plan

Copied some dashboards. See screenshots.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22784.Jun 13 2014, 1:34 AM

epriestley retitled this revision from to Allow entire dashboards to be copied.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 13 2014, 1:34 AM

Harbormaster completed remote builds in B1045: Diff 22784.Jun 13 2014, 1:35 AM

Managing a dashboard you can't edit:

Screen_Shot_2014-06-12_at_6.35.03_PM.png (1×1 px, 235 KB)

Create a copy:

Screen_Shot_2014-06-12_at_6.35.08_PM.png (1×1 px, 215 KB)

Here is your copy:

Screen_Shot_2014-06-12_at_6.35.24_PM.png (1×1 px, 138 KB)

After adjustments, you have a version you can customize:

Screen_Shot_2014-06-12_at_6.35.19_PM.png (1×1 px, 240 KB)

chad accepted this revision.Jun 13 2014, 3:21 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2014, 3:21 AM

Closed by commit rP18757e43de2b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

__phutil_library_map__.php

4 lines

applications/

dashboard/

application/

PhabricatorApplicationDashboard.php

1 line

controller/

PhabricatorDashboardCopyController.php

68 lines

PhabricatorDashboardManageController.php

25 lines

storage/

PhabricatorDashboard.php

10 lines

PhabricatorDashboardPanel.php

5 lines

Diff 22788

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/application/PhabricatorApplicationDashboard.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardCopyController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...