Move icon inside link in ActionLink
ClosedPublic
Actions

Authored by chad on Jun 12 2014, 4:52 PM.

Tags

None

Referenced Files

	F14056980: D9503.diff
	Sat, Nov 16, 11:51 PM

	F14023073: D9503.diff
	Wed, Nov 6, 10:38 PM

	F14013948: D9503.id22762.diff
	Sat, Nov 2, 8:04 PM

	F14007993: D9503.diff
	Tue, Oct 29, 1:47 PM

	F14007839: D9503.diff
	Tue, Oct 29, 12:03 PM

	F13980006: D9503.id.diff
	Oct 19 2024, 7:52 AM

	F13979959: D9503.id22766.diff
	Oct 19 2024, 7:33 AM

	F13979896: D9503.id22766.diff
	Oct 19 2024, 7:05 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5331: Unable to click on icons next to phriction pages

Commits

Restricted Diffusion Commit
rP5dca350e0e79: Move icon inside link in ActionLink

Summary

Moves the icon into the link

Test Plan

Tested a form (Phrequent), disabled, and regular action link

Diff Detail

Repository

rP Phabricator

Branch

action-icons

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1034
Build 1034: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22762.Jun 12 2014, 4:52 PM

chad retitled this revision from to Move icon inside link in ActionLink.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 12 2014, 4:52 PM

Harbormaster completed remote builds in B1034: Diff 22762.Jun 12 2014, 4:53 PM

chad added a task: T5331: Unable to click on icons next to phriction pages.Jun 12 2014, 4:53 PM

epriestley accepted this revision.Jun 12 2014, 5:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 12 2014, 5:23 PM

Closed by commit rP5dca350e0e79 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

view/

layout/

PhabricatorActionView.php

8 lines

Diff 22762

View Options

src/view/layout/PhabricatorActionView.php

Move icon inside link in ActionLinkClosedPublicActions