Page MenuHomePhabricator
Differential D9499

Edit dashboard panels in a dialog instead of on a separate page
ClosedPublic
Actions

Authored by epriestley on Jun 12 2014, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:30 AM
Unknown Object (File)
Sun, Dec 15, 3:50 PM
Unknown Object (File)
Thu, Dec 12, 8:53 AM
Unknown Object (File)
Mon, Dec 9, 2:27 PM
Unknown Object (File)
Mon, Dec 2, 10:05 AM
Unknown Object (File)
Wed, Nov 27, 3:06 PM
Unknown Object (File)
Wed, Nov 27, 1:25 PM
Unknown Object (File)
Sun, Nov 24, 11:04 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPc72e2f35f3db: Edit dashboard panels in a dialog instead of on a separate page
Summary

When you "Edit Panel" on a dashboard, pop a dialog instead of redirecting to a different page.

Test Plan

Edited a panel from a dashboard; edited a panel from the panel workflow.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22756.Jun 12 2014, 10:34 AM
epriestley retitled this revision from to Edit dashboard panels in a dialog instead of on a separate page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 12 2014, 10:34 AM
Harbormaster completed remote builds in B1029: Diff 22756.Jun 12 2014, 10:35 AM
chad accepted this revision.Jun 12 2014, 4:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 12 2014, 4:21 PM
epriestley closed this revision.Jun 12 2014, 8:22 PM
epriestley updated this revision to Diff 22768.

Closed by commit rPc72e2f35f3db (authored by @epriestley).

Revision Contents
Changeset List

Diff 22768

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
Phabricator · Built by Phacility