Page MenuHomePhabricator
Differential D9495

Clean up error state on Dashboards
ClosedPublic
Actions

Authored by chad on Jun 12 2014, 4:53 AM.
Tags
None
Referenced Files
F14352383: D9495.diff
Thu, Dec 19, 1:40 PM
Unknown Object (File)
Fri, Dec 13, 3:10 AM
Unknown Object (File)
Thu, Dec 12, 9:00 AM
Unknown Object (File)
Thu, Dec 12, 9:00 AM
Unknown Object (File)
Thu, Dec 12, 8:55 AM
Unknown Object (File)
Thu, Dec 12, 8:43 AM
Unknown Object (File)
Thu, Dec 12, 12:47 AM
Unknown Object (File)
Sat, Dec 7, 2:24 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5319: Dashboard error panels don't have a background fill
Commits
Restricted Diffusion Commit
rP71d9a6be0743: Clean up error state on Dashboards
Summary

A more basic error view

Test Plan

Made stuff up

undefined (95×681 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Branch
red-panels
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1025
Build 1025: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22751.Jun 12 2014, 4:53 AM
chad retitled this revision from to Clean up error state on Dashboards.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 12 2014, 4:53 AM
chad edited the test plan for this revision. (Show Details)Jun 12 2014, 4:53 AM
Harbormaster completed remote builds in B1025: Diff 22751.Jun 12 2014, 4:54 AM
epriestley accepted this revision.Jun 12 2014, 10:07 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 12 2014, 10:07 AM
chad closed this revision.Jun 12 2014, 2:11 PM
chad updated this revision to Diff 22760.

Closed by commit rP71d9a6be0743 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
dashboard/
engine/
13 lines
webroot/
rsrc/
css/
application/
dashboard/
8 lines

Diff 22751

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
Phabricator · Built by Phacility