Differential D9494

Return the build from applyPlan instead of the plan
ClosedPublic
Actions

Authored by hach-que on Jun 12 2014, 2:59 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP14198d62fb5b: Return the build from applyPlan instead of the plan

Summary

Nothing inside Phabricator uses the return value of this method, but returning the actual build instance is far more useful (for kicking off builds in an application and storing the build PHID against another object).

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

applyplan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1024
Build 1024: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 22748.Jun 12 2014, 2:59 AM

hach-que retitled this revision from to Return the build from applyPlan instead of the plan.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 12 2014, 2:59 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1024: Diff 22748.Jun 12 2014, 3:00 AM

epriestley accepted this revision.Jun 12 2014, 3:01 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 12 2014, 3:01 AM

Closed by commit rP14198d62fb5b (authored by @hach-que, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

HarbormasterBuildable.php

2 lines

Diff 22748

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Return the build from applyPlan instead of the planClosedPublicActions