Page MenuHomePhabricator

Print out stack traces when Aphlict server dies
ClosedPublic

Authored by epriestley on Jun 11 2014, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:43 PM
Unknown Object (File)
Wed, Apr 24, 10:13 PM
Unknown Object (File)
Wed, Apr 24, 4:04 AM
Unknown Object (File)
Sat, Apr 20, 7:03 PM
Unknown Object (File)
Tue, Apr 16, 4:22 AM
Unknown Object (File)
Thu, Apr 11, 8:29 AM
Unknown Object (File)
Sat, Apr 6, 7:30 AM
Unknown Object (File)
Sat, Apr 6, 4:33 AM
Subscribers

Details

Summary

Printing out err is less informative than err.stack, which has the message, type, and a trace.

Test Plan

Faked an exception, then:

$ sudo ./bin/aphlict debug
Starting Aphlict server in foreground...
Launching server:

    $ 'node' '/INSECURE/devtools/phabricator/src/applications/aphlict/management/../../../../support/aphlict/server/aphlict_server.js' --port='22280' --admin='22281' --host='localhost'

[Wed Jun 11 2014 10:20:39 GMT-0700 (PDT)] 
<<< UNCAUGHT EXCEPTION! >>>
Error: Example Exception
    at Object.<anonymous> (/INSECURE/devtools/phabricator/support/aphlict/server/aphlict_server.js:73:7)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3
>>> Server exited!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Print out stack traces when Aphlict server dies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
joshuaspence edited edge metadata.

Yeah, this is much more useful.

This revision is now accepted and ready to land.Jun 11 2014, 5:23 PM
epriestley updated this revision to Diff 22676.

Closed by commit rP60d2b743d900 (authored by @epriestley).