Restore test-sensitive whitespace to some test cases
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 11:30 PM.

Tags

None

Referenced Files

	F19098899: D9462.id22619.diff
	Dec 4 2025, 6:35 PM

	F19098898: D9462.id22618.diff
	Dec 4 2025, 6:35 PM

	F18873121: D9462.diff
	Nov 5 2025, 8:04 AM

	F18820384: D9462.id22618.diff
	Oct 22 2025, 2:36 PM

	F18813956: D9462.diff
	Oct 20 2025, 8:19 PM

	F18793775: D9462.id.diff
	Oct 16 2025, 10:07 PM

	F18776971: D9462.id22619.diff
	Oct 11 2025, 12:21 AM

	F18774299: D9462.id.diff
	Oct 9 2025, 11:45 PM

View All Files

Subscribers

epriestley

Details

Reviewers

hach-que
joshuaspence

Commits

Restricted Diffusion Commit
rP8dafabbb1d95: Restore test-sensitive whitespace to some test cases

Summary

This trailing whitespace is meaningful for these files. Also, exclude test data from linting.

Test Plan

Ran unit tests.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22618.Jun 10 2014, 11:30 PM

epriestley retitled this revision from to Restore test-sensitive whitespace to some test cases.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 11:30 PM

Harbormaster completed remote builds in B980: Diff 22618.Jun 10 2014, 11:31 PM

joshuaspence accepted this revision.Jun 10 2014, 11:32 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jun 10 2014, 11:32 PM

Closed by commit rP8dafabbb1d95 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

.arclint

2 lines

src/

applications/

differential/

parser/

__tests__/

data/

missing_context.diff

1 line

missing_context_2.diff

1 line

missing_context_3.diff

1 line

Diff 22619

View Options

.arclint

View Options

src/applications/differential/parser/tests/data/missing_context.diff

View Options

src/applications/differential/parser/tests/data/missing_context_2.diff

View Options

src/applications/differential/parser/tests/data/missing_context_3.diff

Restore test-sensitive whitespace to some test casesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22619

.arclint

src/applications/differential/parser/__tests__/data/missing_context.diff

src/applications/differential/parser/__tests__/data/missing_context_2.diff

src/applications/differential/parser/__tests__/data/missing_context_3.diff

Restore test-sensitive whitespace to some test cases
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/differential/parser/tests/data/missing_context.diff

src/applications/differential/parser/tests/data/missing_context_2.diff

src/applications/differential/parser/tests/data/missing_context_3.diff