Fix changeset loading issue for "Download Raw Diff" in Differential
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 9:47 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5309: Unhandled Exception ("PhabricatorDataNotAttachedException") when trying to download raw diff in Differential

Commits

Restricted Diffusion Commit
rP0bf19df7c644: Fix changeset loading issue for "Download Raw Diff" in Differential

Summary

Fixes T5309. Modernize this callsite to use ChangesetQuery and pick up attached objects.

Test Plan

Clicked "Download Raw Diff" in Differential.

Diff Detail

Repository

rP Phabricator

Branch

rawdiff

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 975
Build 975: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22595.Jun 10 2014, 9:47 PM

epriestley retitled this revision from to Fix changeset loading issue for "Download Raw Diff" in Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5309: Unhandled Exception ("PhabricatorDataNotAttachedException") when trying to download raw diff in Differential.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 9:47 PM

Harbormaster completed remote builds in B975: Diff 22595.Jun 10 2014, 9:48 PM

chad accepted this revision.Jun 10 2014, 10:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 10 2014, 10:25 PM

Closed by commit rP0bf19df7c644 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

13 lines

Diff 22595

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Fix changeset loading issue for "Download Raw Diff" in DifferentialClosedPublicActions