Page MenuHomePhabricator
Differential D9451

Make named lookup of users case insensitive
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 11:59 AM.
Tags
None
Referenced Files
F14383821: D9451.diff
Sat, Dec 21, 8:53 AM
Unknown Object (File)
Fri, Dec 13, 2:05 AM
Unknown Object (File)
Thu, Dec 12, 8:53 AM
Unknown Object (File)
Wed, Dec 4, 3:04 AM
Unknown Object (File)
Tue, Nov 26, 5:03 PM
Unknown Object (File)
Nov 18 2024, 1:22 AM
Unknown Object (File)
Nov 10 2024, 2:13 AM
Unknown Object (File)
Oct 27 2024, 4:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
sophiebits
chad
Maniphest Tasks
T5302: Conduit phid.lookup is case sensitive
Commits
Restricted Diffusion Commit
rP28341307922c: Make named lookup of users case insensitive
Summary

Fixes T5302. Allow the name @aLiNCoLN to identify user @alincoln.

Test Plan

Queried users with mixed case names.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22558.Jun 10 2014, 11:59 AM
epriestley retitled this revision from to Make named lookup of users case insensitive.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: sophiebits, btrahan.
epriestley added a task: T5302: Conduit phid.lookup is case sensitive.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 11:59 AM
Harbormaster completed remote builds in B955: Diff 22558.Jun 10 2014, 12:00 PM
sophiebits accepted this revision.Jun 10 2014, 6:35 PM
sophiebits edited edge metadata.
sophiebits added inline comments.
src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php
71

Just to verify my understanding – this transformation isn't necessary for the query, just for matching the objects up afterwards?

This revision is now accepted and ready to land.Jun 10 2014, 6:35 PM
epriestley added a reviewer: chad.Jun 10 2014, 7:16 PM

Yep, that's correct. The query itself finds usernames in either case (which is how the user.query version works), but we currently discard them on the way out.

epriestley closed this revision.Jun 10 2014, 7:17 PM
epriestley updated this revision to Diff 22577.

Closed by commit rP28341307922c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
people/
phid/
6 lines

Diff 22577

View Options

src/applications/people/phid/PhabricatorPeoplePHIDTypeUser.php

Loading...
Phabricator · Built by Phacility