Page MenuHomePhabricator
Differential D9449

Apply linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Jun 10 2014, 1:01 AM.
Tags
None
Referenced Files
F14237048: D9449.diff
Thu, Dec 12, 11:49 AM
F14235692: D9449.id.diff
Thu, Dec 12, 8:53 AM
Unknown Object (File)
Tue, Dec 10, 5:07 PM
Unknown Object (File)
Sun, Dec 8, 11:42 AM
Unknown Object (File)
Wed, Dec 4, 7:24 AM
Unknown Object (File)
Sat, Nov 30, 5:58 AM
Unknown Object (File)
Tue, Nov 26, 5:35 PM
Unknown Object (File)
Mon, Nov 25, 8:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
rJXbdb2af92d8c4: Apply linter fixes
Summary

Apply various linter fixes.

Test Plan

Eyeballed it.

Diff Detail

Repository
rJX Javelin
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22554.Jun 10 2014, 1:01 AM
joshuaspence retitled this revision from to Apply linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added reviewers: Blessed Reviewers, chad. · View Herald TranscriptJun 10 2014, 1:01 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B952: Diff 22554.Jun 10 2014, 1:02 AM
epriestley accepted this revision.Jun 10 2014, 5:59 PM
epriestley edited edge metadata.

The Diviner stuff is very old code for the very old Diviner. I think it's OK to leave it for now, since it hasn't had a replacement written and can still technically run with old Diviner.

This revision is now accepted and ready to land.Jun 10 2014, 5:59 PM
epriestley closed this revision.Jun 10 2014, 5:59 PM
epriestley updated this revision to Diff 22571.

Closed by commit rJXbdb2af92d8c4 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
2 lines
1 line
example/
php-tictactoe/
2 lines
php-typeahead/
2 lines
pkg/
2 lines
2 lines
2 lines
2 lines
scripts/
2 lines
specs/
jasmine/
6 lines
10 lines
src/
core/
__tests__/
4 lines
1 line
docs/
5 lines
concepts/
1 line
1 line
ext/
reactor/
core/
1 line
1 line
1 line
1 line
dom/
2 lines
view/
1 line
1 line
1 line
1 line
lib/
1 line
__tests__/
3 lines
1 line
control/
typeahead/
source/
1 line
2 lines
3 lines
3 lines
support/
diviner/
engine/
2 lines
jsxmin/
4 lines
2 lines
2 lines
6 lines
php/
13 lines

Diff 22571

View Options

.gitignore

Loading...
View Options

LICENSE

Loading...
View Options

example/php-tictactoe/ai.php

Loading...
View Options

example/php-typeahead/animals.txt

Loading...
View Options

pkg/init.min.js

Loading...
View Options

pkg/javelin.min.js

Loading...
View Options

pkg/typeahead.min.js

Loading...
View Options

pkg/workflow.min.js

Loading...
View Options

scripts/build.sh

Loading...
View Options

specs/jasmine/jasmine.css

Loading...
View Options

specs/jasmine/jasmine.js

Loading...
View Options

src/core/__tests__/event-stop-and-kill.js

Loading...
View Options

src/core/__tests__/install.js

Loading...
View Options

src/docs/Base.js

Loading...
View Options

src/docs/concepts/behaviors.diviner

Loading...
View Options

src/docs/onload.js

Loading...
View Options

src/ext/reactor/core/DynVal.js

Loading...
View Options

src/ext/reactor/core/Reactor.js

Loading...
View Options

src/ext/reactor/core/ReactorNode.js

Loading...
View Options

src/ext/reactor/core/ReactorNodeCalmer.js

Loading...
View Options

src/ext/reactor/dom/RDOM.js

Loading...
View Options

src/ext/view/HTMLView.js

Loading...
View Options

src/ext/view/View.js

Loading...
View Options

src/ext/view/ViewRenderer.js

Loading...
View Options

src/ext/view/ViewVisitor.js

Loading...
View Options

src/lib/DOM.js

Loading...
View Options

src/lib/__tests__/URI.js

Loading...
View Options

src/lib/__tests__/behavior.js

Loading...
View Options

src/lib/control/typeahead/source/TypeaheadCompositeSource.js

Loading...
View Options

src/lib/control/typeahead/source/TypeaheadOnDemandSource.js

Loading...
View Options

src/lib/control/typeahead/source/TypeaheadPreloadedSource.js

Loading...
View Options

src/lib/control/typeahead/source/TypeaheadStaticSource.js

Loading...
View Options

support/diviner/engine/JavelinDivinerEngine.php

Loading...
View Options

support/jsxmin/jsxmin_main.cpp

Loading...
View Options

support/jsxmin/jsxmin_reduction.cpp

Loading...
View Options

support/jsxmin/reduce.hpp

Loading...
View Options

support/jsxmin/reduce.cpp

Loading...
View Options

support/php/JavelinHelper.php

Loading...
Phabricator · Built by Phacility