Page MenuHomePhabricator

Lint the `ArcanistSpellingDefaultData` class.
ClosedPublic

Authored by joshuaspence on Jun 9 2014, 5:48 PM.
Tags
None
Referenced Files
F13211373: D9432.id22522.diff
Fri, May 17, 5:42 AM
F13210484: D9432.diff
Fri, May 17, 4:54 AM
F13196124: D9432.diff
Sun, May 12, 10:58 PM
F13180409: D9432.id.diff
Wed, May 8, 11:47 PM
Unknown Object (File)
Fri, May 3, 2:45 AM
Unknown Object (File)
Thu, May 2, 7:52 AM
Unknown Object (File)
Mon, Apr 29, 2:12 PM
Unknown Object (File)
Wed, Apr 24, 8:53 PM
Subscribers

Details

Summary

Currently, the ArcanistSpellingDefaultData is marked with a @nolint annotation. This means that it doesn't get linted by any linters. Really, the intention here was to make sure that this file isn't linted by the ArcanistSpellingLinter linter.

Now that the .arclint file is more mature, we can easily just exclude this file from being linted only by the spelling linter, whilst allowing other linters to run.

Test Plan

Ran arc lint.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Lint the `ArcanistSpellingDefaultData` class..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2014, 6:35 PM
epriestley updated this revision to Diff 22522.

Closed by commit rARC833ce4515566 (authored by @joshuaspence, committed by @epriestley).