Page MenuHomePhabricator
Differential D9413

Make App Pinning use Stackable list
ClosedPublic
Actions

Authored by chad on Jun 6 2014, 10:26 PM.
Tags
None
Referenced Files
F14855126: D9413.diff
Wed, Feb 5, 10:20 AM
Unknown Object (File)
Sun, Feb 2, 9:30 PM
Unknown Object (File)
Wed, Jan 29, 11:18 AM
Unknown Object (File)
Fri, Jan 24, 11:39 PM
Unknown Object (File)
Fri, Jan 24, 8:47 AM
Unknown Object (File)
Fri, Jan 24, 4:38 AM
Unknown Object (File)
Dec 13 2024, 9:04 PM
Unknown Object (File)
Nov 23 2024, 11:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb1362e4e46e0: Make App Pinning use Stackable list
Summary

This makes setStackble play well in ObjectBox, also tweaks dragging in a stackable box (pinning)

Test Plan

Drag in App Settings, Drag in Maniphest, Workboards

Diff Detail

Repository
rP Phabricator
Branch
launcher
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/css/phui/phui-object-item-list-view.css:213TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 908
Build 908: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22465.Jun 6 2014, 10:26 PM
chad retitled this revision from to Make App Pinning use Stackable list.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 6 2014, 10:26 PM
Harbormaster completed remote builds in B908: Diff 22465.Jun 6 2014, 10:27 PM
epriestley accepted this revision.Jun 7 2014, 6:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 6:26 PM
chad closed this revision.Jun 7 2014, 6:28 PM
chad updated this revision to Diff 22477.

Closed by commit rPb1362e4e46e0 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
settings/
panel/
2 lines
webroot/
rsrc/
css/
phui/
38 lines

Diff 22465

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility