Page MenuHomePhabricator
Differential D9411

Mark some ActionScript methods as `final`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 6 2014, 8:28 PM.
Tags
None
Referenced Files
F14812194: D9411.id22480.diff
Mon, Jan 27, 6:18 AM
Unknown Object (File)
Fri, Jan 24, 9:32 AM
Unknown Object (File)
Thu, Jan 23, 9:22 PM
Unknown Object (File)
Tue, Jan 21, 3:04 PM
Unknown Object (File)
Fri, Jan 17, 10:08 PM
Unknown Object (File)
Sat, Jan 4, 2:10 AM
Unknown Object (File)
Fri, Jan 3, 1:07 AM
Unknown Object (File)
Wed, Jan 1, 8:35 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP7f9a6626a0c4: Mark some ActionScript methods as `final`.
Summary

These methods shouldn't be overridden. Marking them as final will enforce this.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22463.Jun 6 2014, 8:28 PM
joshuaspence retitled this revision from to Mark some ActionScript methods as `final`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 6 2014, 8:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B906: Diff 22463.Jun 6 2014, 8:30 PM
epriestley accepted this revision.Jun 7 2014, 6:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 6:31 PM
epriestley closed this revision.Jun 7 2014, 6:35 PM
epriestley updated this revision to Diff 22480.

Closed by commit rP7f9a6626a0c4 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
src/
9 lines
2 lines
2 lines
webroot/
rsrc/
swf/

Diff 22480

View Options

support/aphlict/client/src/Aphlict.as

Loading...
View Options

support/aphlict/client/src/AphlictClient.as

Loading...
View Options

support/aphlict/client/src/AphlictMaster.as

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility