Page MenuHomePhabricator
Differential D9411

Mark some ActionScript methods as `final`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 6 2014, 8:28 PM.
Tags
None
Referenced Files
F19098920: D9411.id22480.diff
Thu, Dec 4, 6:39 PM
F18833748: D9411.id22480.diff
Oct 26 2025, 5:27 AM
F18833342: D9411.diff
Oct 26 2025, 2:38 AM
F18799409: D9411.id.diff
Oct 17 2025, 1:46 PM
F18791381: D9411.diff
Oct 16 2025, 11:18 AM
F18737968: D9411.diff
Oct 1 2025, 1:31 PM
F18611079: D9411.id22480.diff
Sep 14 2025, 6:09 AM
F18084333: D9411.id.diff
Aug 5 2025, 2:59 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP7f9a6626a0c4: Mark some ActionScript methods as `final`.
Summary

These methods shouldn't be overridden. Marking them as final will enforce this.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22463.Jun 6 2014, 8:28 PM
joshuaspence retitled this revision from to Mark some ActionScript methods as `final`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 6 2014, 8:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B906: Diff 22463.Jun 6 2014, 8:30 PM
epriestley accepted this revision.Jun 7 2014, 6:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 6:31 PM
epriestley closed this revision.Jun 7 2014, 6:35 PM
epriestley updated this revision to Diff 22480.

Closed by commit rP7f9a6626a0c4 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
src/
9 lines
2 lines
2 lines
webroot/
rsrc/
swf/

Diff 22480

View Options

support/aphlict/client/src/Aphlict.as

Loading...
View Options

support/aphlict/client/src/AphlictClient.as

Loading...
View Options

support/aphlict/client/src/AphlictMaster.as

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility