Page MenuHomePhabricator

Fix bugs in python lexer
ClosedPublic

Authored by sophiebits on Jun 6 2014, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 10:12 PM
Unknown Object (File)
Fri, Mar 15, 9:31 PM
Unknown Object (File)
Mon, Mar 4, 6:26 PM
Unknown Object (File)
Feb 23 2024, 9:12 PM
Unknown Object (File)
Feb 5 2024, 6:50 PM
Unknown Object (File)
Feb 4 2024, 3:58 AM
Unknown Object (File)
Jan 5 2024, 1:07 PM
Unknown Object (File)
Dec 28 2023, 5:03 PM
Subscribers

Details

Summary

Two things:

  • The appearance of \\ or \' or \-followed-by-a-newline in a raw string would improperly end the string
  • A disallowed newline in a string would cause an error instead of trying to continue anyway
Test Plan

Ran it on a file that was failing for me that was something like:

x = r'\\"'
# hello there

Diff Detail

Repository
rPHU libphutil
Branch
pylex2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 892
Build 892: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

sophiebits retitled this revision from to Fix bugs in python lexer.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2014, 12:25 AM
epriestley updated this revision to Diff 22445.

Closed by commit rPHU7e75bf271c66 (authored by @spicyj, committed by @epriestley).