Page MenuHomePhabricator

Fix countdown embeds and endless loops on resource loads in Javelin
ClosedPublic

Authored by epriestley on Jun 5 2014, 10:08 PM.
Tags
None
Referenced Files
F16571833: D9399.diff
Tue, Jun 17, 3:31 AM
Unknown Object (File)
Sun, Jun 15, 6:47 AM
Unknown Object (File)
Sat, Jun 14, 12:23 AM
Unknown Object (File)
Mon, Jun 9, 2:22 AM
Unknown Object (File)
Sun, Jun 1, 11:57 PM
Unknown Object (File)
Sun, Jun 1, 5:24 PM
Unknown Object (File)
Sun, Jun 1, 4:20 AM
Unknown Object (File)
Sat, May 31, 5:49 AM
Subscribers

Details

Summary

Fixes T5273. Two issues:

  • If a JX.Resource callback throws, we keep running it. Instead, make sure it gets cleaned up before raising an exception.
  • The countdown timer script doesn't recover gracefully if the node has been removed from the document by the time it runs. Instead, just bail if we can't find the countdown.
Test Plan

Dumped {Cxyz} into a preview and got a countdown.

Diff Detail

Repository
rP Phabricator
Branch
countdown
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 885
Build 885: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix countdown embeds and endless loops on resource loads in Javelin.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: yungsters.
yungsters edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2014, 11:07 PM
epriestley updated this revision to Diff 22435.

Closed by commit rPd06679a0214c (authored by @epriestley).