Page MenuHomePhabricator

Fix countdown embeds and endless loops on resource loads in Javelin
ClosedPublic

Authored by epriestley on Jun 5 2014, 10:08 PM.
Tags
None
Referenced Files
F19863881: D9399.id22424.diff
Sat, Mar 14, 1:23 PM
F19835730: D9399.diff
Wed, Mar 11, 7:53 AM
F19605908: D9399.id22435.diff
Feb 3 2026, 9:42 AM
F19534361: D9399.diff
Jan 20 2026, 11:44 PM
F19511831: D9399.id22435.diff
Jan 12 2026, 8:19 AM
F19057852: D9399.id.diff
Nov 28 2025, 11:56 PM
F19044662: D9399.diff
Nov 27 2025, 4:03 AM
F18837541: D9399.id22424.diff
Oct 27 2025, 6:05 AM
Subscribers

Details

Summary

Fixes T5273. Two issues:

  • If a JX.Resource callback throws, we keep running it. Instead, make sure it gets cleaned up before raising an exception.
  • The countdown timer script doesn't recover gracefully if the node has been removed from the document by the time it runs. Instead, just bail if we can't find the countdown.
Test Plan

Dumped {Cxyz} into a preview and got a countdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix countdown embeds and endless loops on resource loads in Javelin.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: yungsters.
yungsters edited edge metadata.
This revision is now accepted and ready to land.Jun 5 2014, 11:07 PM
epriestley updated this revision to Diff 22435.

Closed by commit rPd06679a0214c (authored by @epriestley).