Page MenuHomePhabricator
Differential D9360

Use "https://" instead of "git://" for anoymous GitHub requests in documentation
ClosedPublic
Actions

Authored by epriestley on Jun 3 2014, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 4:19 AM
Unknown Object (File)
Mon, Apr 29, 2:50 PM
Unknown Object (File)
Wed, Apr 24, 10:16 PM
Unknown Object (File)
Tue, Apr 9, 1:06 PM
Unknown Object (File)
Apr 4 2024, 3:37 PM
Unknown Object (File)
Feb 14 2024, 10:55 AM
Unknown Object (File)
Feb 14 2024, 10:55 AM
Unknown Object (File)
Feb 14 2024, 10:54 AM
View All Files
Subscribers
avivey
epriestley

Details

Reviewers
avivey
chad
• avive
Commits
Restricted Diffusion Commit
rPe3d7c16d8c85: Use "https://" instead of "git://" for anoymous GitHub requests in documentation
Summary

These both work, but "git://" uses a nonstandard and possibly firewalled port, is less familiar to users, and is not promoted in the GitHub UI.

Test Plan

grep, reviewed diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22286.Jun 3 2014, 4:35 PM
epriestley retitled this revision from to Use "https://" instead of "git://" for anoymous GitHub requests in documentation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, • avive.
Herald added subscribers: avivey, epriestley. · View Herald TranscriptJun 3 2014, 4:35 PM
epriestley added a comment.Jun 3 2014, 4:35 PM

https is also presumably more difficult to MITM.

Harbormaster completed remote builds in B823: Diff 22286.Jun 3 2014, 4:36 PM
avivey accepted this revision.Jun 3 2014, 4:38 PM
avivey added a reviewer: avivey.

worksforme

This revision is now accepted and ready to land.Jun 3 2014, 4:38 PM
epriestley closed this revision.Jun 3 2014, 4:40 PM
epriestley updated this revision to Diff 22288.

Closed by commit rPe3d7c16d8c85 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
scripts/
install/
6 lines
6 lines
src/
docs/
user/
6 lines
userguide/
4 lines
4 lines

Diff 22288

View Options

scripts/install/install_rhel-derivs.sh

Loading...
View Options

scripts/install/install_ubuntu.sh

Loading...
View Options

src/docs/user/installation_guide.diviner

Loading...
View Options

src/docs/user/userguide/arcanist.diviner

Loading...
View Options

src/docs/user/userguide/arcanist_quick_start.diviner

Loading...
Phabricator · Built by Phacility