Page MenuHomePhabricator

(Redesign) Clean up older "Tile" code
ClosedPublic

Authored by epriestley on Jun 3 2014, 3:11 PM.
Tags
None
Referenced Files
F13818272: D9358.diff
Fri, Sep 20, 6:31 AM
Unknown Object (File)
Wed, Sep 4, 9:36 AM
Unknown Object (File)
Fri, Aug 30, 11:34 PM
Unknown Object (File)
Mon, Aug 26, 8:55 AM
Unknown Object (File)
Mon, Aug 26, 2:10 AM
Unknown Object (File)
Aug 17 2024, 2:40 PM
Unknown Object (File)
Jul 21 2024, 2:25 PM
Unknown Object (File)
Jul 14 2024, 3:48 PM
Subscribers

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP6df1a024137c: (Redesign) Clean up older "Tile" code
Summary

This does some backend cleanup of the tile stuff, and some general cleanup of other application things:

  • Users who haven't customized preferences get a small, specific set of pinned applications: Differential, Maniphest, Diffusion, Audit, Phriction, Projects (and, for administrators, Auth, Config and People).
  • Old tile size methods are replaced with isPinnnedByDefault().
  • Shortened some short descriptions.
  • shouldAppearInLaunchView() replaced by less ambiguous isLaunchable().
  • Added a marker for third-party / extension applications.
Test Plan

Faked away my preferences and viewed the home page, saw a smaller set of default pins.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to (Redesign) Clean up older "Tile" code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Pin Phriction and Projects by default.
chad edited edge metadata.
chad added inline comments.
src/applications/meta/query/PhabricatorAppSearchEngine.php
229

fa-times ?

This revision is now accepted and ready to land.Jun 3 2014, 8:07 PM
src/applications/meta/query/PhabricatorAppSearchEngine.php
229

Oh, good catch.

epriestley updated this revision to Diff 22314.

Closed by commit rP6df1a024137c (authored by @epriestley).