Fix an issues with moved Phriction documents if the old location does not exist or can't be loaded
ClosedPublic
Actions

Authored by epriestley on Jun 3 2014, 1:21 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5250: Exception when accessing document of a renamed project

Commits

Restricted Diffusion Commit
rP75cbc3ef6c0e: Fix an issues with moved Phriction documents if the old location does not exist…

Summary

Fixes T5250. This needs some general cleanup, but fix the fatal.

Test Plan

Viewed moved document.
Viewed moved-from-nonexistent-source document.

Diff Detail

Repository

rP Phabricator

Branch

wiki1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 819
Build 819: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22282.Jun 3 2014, 1:21 PM

epriestley retitled this revision from to Fix an issues with moved Phriction documents if the old location does not exist or can't be loaded.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5250: Exception when accessing document of a renamed project.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 3 2014, 1:21 PM

Harbormaster completed remote builds in B819: Diff 22282.Jun 3 2014, 1:23 PM

chad accepted this revision.Jun 3 2014, 7:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2014, 7:03 PM

Closed by commit rP75cbc3ef6c0e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDocumentController.php

40 lines

Diff 22282

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Fix an issues with moved Phriction documents if the old location does not exist or can't be loadedClosedPublicActions