Page MenuHomePhabricator
Differential D9352

Allow projects to be deleted with `./bin/remove destroy`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2014, 11:59 PM.
Tags
None
Referenced Files
F15418303: D9352.diff
Thu, Mar 20, 10:23 PM
F15398080: D9352.id22270.diff
Sun, Mar 16, 11:15 PM
F15388019: D9352.id22270.diff
Sat, Mar 15, 3:12 AM
F15337721: D9352.id22270.diff
Sun, Mar 9, 7:19 AM
F15335258: D9352.id22270.diff
Sat, Mar 8, 2:45 PM
F15333284: D9352.id22270.diff
Sat, Mar 8, 1:37 AM
Unknown Object (File)
Sat, Mar 1, 2:39 PM
Unknown Object (File)
Tue, Feb 25, 8:53 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5235: Implement `PhabricatorDestructableInterface` on `PhabricatorProject`
Commits
Restricted Diffusion Commit
rPc2eff7c2163c: Allow projects to be deleted with `./bin/remove destroy`.
Summary

Fixes T5235. Implement PhabricatorDestructableInterface on PhabricatorProject so that projects can be deleted with ./bin/remove destroy.

Test Plan

Created (and then destroyed) a test project. Verified that the corresponding objects (project, slugs and workboard columns) were removed from the database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22268.Jun 2 2014, 11:59 PM
joshuaspence retitled this revision from to Allow projects to be deleted with `./bin/remove destroy`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5235: Implement `PhabricatorDestructableInterface` on `PhabricatorProject`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2014, 11:59 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B808: Diff 22268.Jun 3 2014, 12:00 AM
joshuaspence added a comment.Jun 3 2014, 12:01 AM

Hmm... I don't think this is cleaning up all of the edges. I had also created a maniphest under the test project, which now displays as "Unknown Object" (whereas I was expecting the project to be removed from the maniphest competely).

epriestley accepted this revision.Jun 3 2014, 12:09 AM
epriestley edited edge metadata.

IIRC, Maniphest doesn't use edges to record projects right now. It should, it just predates the edge infrastructure.

This revision is now accepted and ready to land.Jun 3 2014, 12:09 AM
epriestley closed this revision.Jun 3 2014, 12:10 AM
epriestley updated this revision to Diff 22270.

Closed by commit rPc2eff7c2163c (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
project/
storage/
26 lines
14 lines

Diff 22270

View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumn.php

Loading...
Phabricator · Built by Phacility