Don't set the default size and background color for the Aphlict client SWF.
ClosedPublic
Actions

Authored by joshuaspence on May 30 2014, 5:46 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP802463cb946f: Don't set the default size and background color for the Aphlict client SWF.

Summary

These settings don't seem to make any difference and are somewhat confusing.

Test Plan

Sent myself test notifications via /notification/status. Things seemed to work.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22241.May 30 2014, 5:46 AM

joshuaspence retitled this revision from to Don't set the default size and background color for the Aphlict client SWF..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 30 2014, 5:46 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B790: Diff 22241.May 30 2014, 5:47 AM

epriestley accepted this revision.May 30 2014, 10:17 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 30 2014, 10:17 AM

Closed by commit rP802463cb946f (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

support/

aphlict/

client/

build_aphlict_client.sh

2 lines

Diff 22245

View Options

support/aphlict/client/build_aphlict_client.sh

Don't set the default size and background color for the Aphlict client SWF.ClosedPublicActions