Page MenuHomePhabricator

Don't attempt to discover parents commits for untracked branchs.
ClosedPublic

Authored by joshuaspence on May 28 2014, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 4:17 AM
Unknown Object (File)
Thu, Dec 12, 6:41 AM
Unknown Object (File)
Tue, Nov 26, 9:15 PM
Unknown Object (File)
Mon, Nov 25, 1:56 AM
Unknown Object (File)
Fri, Nov 22, 6:23 PM
Unknown Object (File)
Nov 17 2024, 10:07 PM
Unknown Object (File)
Nov 14 2024, 9:48 AM
Unknown Object (File)
Nov 10 2024, 10:06 AM
Subscribers

Details

Summary

Fixes T5195. Currently, the ./bin/repository parents workflow doesn't respect tracked branches and will attempt to build parents caches for all branches.

Test Plan

For at least one of our repositories, this patch fixes the Unknown commit exception. Unfortunately, it doesn't seem to completely solve this problem though, but I suspect that this is due to commits that were overwritten with a git push --force or similar.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Don't attempt to discover parents commits for untracked branchs..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 29 2014, 7:02 PM
epriestley updated this revision to Diff 22229.

Closed by commit rP2f668493a0fb (authored by @joshuaspence, committed by @epriestley).