Page MenuHomePhabricator
Differential D9321

T4446: Fix Elasticsearch support for 1.0 and above
ClosedPublic
Actions

Authored by WikiChad on May 28 2014, 8:34 PM.
Tags
None
Referenced Files
F13150825: D9321.id22120.diff
Sat, May 4, 5:49 PM
Unknown Object (File)
Fri, May 3, 7:26 AM
Unknown Object (File)
Sun, Apr 28, 10:20 PM
Unknown Object (File)
Sun, Apr 28, 2:14 AM
Unknown Object (File)
Fri, Apr 26, 6:15 PM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Sat, Apr 20, 6:58 PM
Unknown Object (File)
Wed, Apr 17, 12:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4446: ElasticSearch integration no longer works with 1.0.0
Commits
Restricted Diffusion Commit
rPdd3dfde98360: T4446: Fix Elasticsearch support for 1.0 and above
Summary

Elasticsearch 1.0 deprecated the "filter" top-level
parameter in favor of "post_filter" which is applied
after scores and so forth are calculated.

Instead search field.corpus with a term query.

Test Plan

Tested against Elasticsearch 1.1.1, able to perform
basic queries without query parse errors.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 745
Build 745: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

WikiChad updated this revision to Diff 22118.May 28 2014, 8:34 PM
WikiChad retitled this revision from to T4446: Fix Elasticsearch support for 1.0 and above.
WikiChad updated this object.
WikiChad edited the test plan for this revision. (Show Details)
WikiChad added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 28 2014, 8:34 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B745: Diff 22118.May 28 2014, 8:35 PM
epriestley edited edge metadata.May 28 2014, 10:09 PM

Does this work prior to 1.0 too?

WikiChad added a comment.May 28 2014, 10:13 PM

It should, but I'll double check.

WikiChad added a comment.May 28 2014, 10:27 PM

Just tested against a fresh build of v0.90.9, worked just fine still.

epriestley accepted this revision.May 28 2014, 10:36 PM
epriestley edited edge metadata.

Cool, thanks!

This revision is now accepted and ready to land.May 28 2014, 10:36 PM
epriestley closed this revision.May 28 2014, 10:36 PM
epriestley updated this revision to Diff 22120.

Closed by commit rPdd3dfde98360 (authored by @WikiChad, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
search/
engine/
2 lines

Diff 22118

View Options

src/applications/search/engine/PhabricatorSearchEngineElastic.php

Loading...
Phabricator · Built by Phacility