Page MenuHomePhabricator

T4446: Fix Elasticsearch support for 1.0 and above
ClosedPublic

Authored by WikiChad on May 28 2014, 8:34 PM.
Tags
None
Referenced Files
F18658655: D9321.diff
Tue, Sep 23, 7:42 AM
F18655523: D9321.diff
Mon, Sep 22, 8:09 PM
F18651992: D9321.id22118.diff
Sun, Sep 21, 6:14 AM
F18619928: D9321.id22120.diff
Mon, Sep 15, 3:46 AM
F18557801: D9321.id.diff
Mon, Sep 8, 8:07 PM
F18233741: D9321.id.diff
Aug 20 2025, 5:00 PM
F18105614: D9321.id22118.diff
Aug 10 2025, 6:54 PM
F17945796: D9321.diff
Jul 31 2025, 12:59 PM
Subscribers

Details

Summary

Elasticsearch 1.0 deprecated the "filter" top-level
parameter in favor of "post_filter" which is applied
after scores and so forth are calculated.

Instead search field.corpus with a term query.

Test Plan

Tested against Elasticsearch 1.1.1, able to perform
basic queries without query parse errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

WikiChad retitled this revision from to T4446: Fix Elasticsearch support for 1.0 and above.
WikiChad updated this object.
WikiChad edited the test plan for this revision. (Show Details)
WikiChad added a reviewer: epriestley.

Does this work prior to 1.0 too?

It should, but I'll double check.

Just tested against a fresh build of v0.90.9, worked just fine still.

epriestley edited edge metadata.

Cool, thanks!

This revision is now accepted and ready to land.May 28 2014, 10:36 PM
epriestley updated this revision to Diff 22120.

Closed by commit rPdd3dfde98360 (authored by @WikiChad, committed by @epriestley).