Remove oneline feed story
ClosedPublic
Actions

Authored by chad on May 28 2014, 3:13 PM.

Tags

None

Referenced Files

	F14721873: D9320.id22116.diff
	Fri, Jan 17, 11:03 PM

	Unknown Object (File)
	Fri, Jan 17, 6:09 PM

	Unknown Object (File)
	Fri, Jan 17, 5:10 AM

	Unknown Object (File)
	Fri, Jan 17, 5:10 AM

	Unknown Object (File)
	Fri, Jan 17, 5:10 AM

	Unknown Object (File)
	Fri, Jan 17, 4:45 AM

	Unknown Object (File)
	Sat, Jan 11, 12:12 PM

	Unknown Object (File)
	Tue, Dec 31, 6:46 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPc7a7574f0c8e: Remove oneline feed story

Summary

People seem confused and it is a little inconsistent. Also added other app icon types.

Test Plan

Viewed a number of feed stories.

Diff Detail

Repository

rP Phabricator

Branch

feed-image

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 744
Build 744: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22116.May 28 2014, 3:13 PM

chad retitled this revision from to Remove oneline feed story.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 28 2014, 3:13 PM

Harbormaster completed remote builds in B744: Diff 22116.May 28 2014, 3:14 PM

epriestley accepted this revision.May 28 2014, 3:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 28 2014, 3:59 PM

Closed by commit rPc7a7574f0c8e (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIFeedStoryView.php

48 lines

Diff 22116

View Options

src/view/phui/PHUIFeedStoryView.php

Remove oneline feed storyClosedPublicActions