Fix Diffusion blame/highlight for logged-out users
ClosedPublic
Actions

Authored by epriestley on May 27 2014, 8:26 PM.

Details

Reviewers

vrana
btrahan

Maniphest Tasks

T5199: Anonymous users couldn't display blame

Commits

Restricted Diffusion Commit
rP2aef04a78afb: Fix Diffusion blame/highlight for logged-out users

Summary

Fixes T5199. We try to save these options in user preferences, but logged-out users don't have preferences.

Instead, just use GET links for logged-out users.

Test Plan

As a logged-out user, toggled blame and highlight on and off.
As a logged-in user, toggled blame and highlight on and off.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22087.May 27 2014, 8:26 PM

epriestley retitled this revision from to Fix Diffusion blame/highlight for logged-out users.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: vrana, btrahan.

epriestley added a task: T5199: Anonymous users couldn't display blame.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 27 2014, 8:26 PM

Harbormaster completed remote builds in B724: Diff 22087.May 27 2014, 8:27 PM

vrana accepted this revision.May 28 2014, 12:37 AM

vrana edited edge metadata.

This revision is now accepted and ready to land.May 28 2014, 12:37 AM

Closed by commit rP2aef04a78afb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

9 lines

Diff 22100

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Fix Diffusion blame/highlight for logged-out usersClosedPublicActions