Page MenuHomePhabricator

Remove dedicated "Jump Nav" navigation element
ClosedPublic

Authored by lpriestley on May 26 2014, 5:48 PM.
Tags
None
Referenced Files
F13083305: D9301.diff
Wed, Apr 24, 10:29 PM
Unknown Object (File)
Wed, Apr 24, 7:00 AM
Unknown Object (File)
Thu, Apr 11, 9:04 AM
Unknown Object (File)
Thu, Mar 28, 9:20 AM
Unknown Object (File)
Mar 5 2024, 6:14 AM
Unknown Object (File)
Feb 8 2024, 11:01 PM
Unknown Object (File)
Jan 23 2024, 6:19 AM
Unknown Object (File)
Jan 23 2024, 6:19 AM
Subscribers

Details

Summary

Fixes T5175. Not sure if I cleaned out everything, but this seemed like a reasonable first pass. Attempted to delete all code that belonged to Jump Nav feature only.

Test Plan

Open phabricator homepage, verify Jump Nav element is gone, verify the Search bar still autocompletes and jumps to shortcuts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lpriestley retitled this revision from to Remove dedicated "Jump Nav" navigation element.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

This looks like everything to me.

This revision is now accepted and ready to land.May 26 2014, 6:15 PM
epriestley updated this revision to Diff 22075.

Closed by commit rP607f4bfab8d1 (authored by @lpriestley, committed by @epriestley).