Page MenuHomePhabricator
Differential D9281

Make panels decide async rendering nonrandomly
ClosedPublic
Actions

Authored by epriestley on May 24 2014, 5:47 PM.
Tags
None
Referenced Files
F14063084: D9281.diff
Mon, Nov 18, 4:34 PM
F14052287: D9281.diff
Fri, Nov 15, 8:03 AM
F14043775: D9281.id22041.diff
Tue, Nov 12, 12:49 PM
F14040227: D9281.diff
Mon, Nov 11, 8:07 AM
F14027874: D9281.id22320.diff
Fri, Nov 8, 10:03 AM
F14023217: D9281.diff
Thu, Nov 7, 12:06 AM
F14005402: D9281.id22041.diff
Sun, Oct 27, 12:29 PM
F13985301: D9281.diff
Sun, Oct 20, 7:33 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rPbad7f3d49b38: Make panels decide async rendering nonrandomly
Summary

Ref T4986. The random rule was useful for making sure stuff works, but it works now.

Test Plan

Loaded some dashboards, got consistent async vs non-async.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22041.May 24 2014, 5:47 PM
epriestley retitled this revision from to Make panels decide async rendering nonrandomly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 24 2014, 5:47 PM
Harbormaster completed remote builds in B687: Diff 22041.May 24 2014, 5:48 PM
btrahan accepted this revision.Jun 3 2014, 9:50 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 9:50 PM
epriestley closed this revision.Jun 3 2014, 11:51 PM
epriestley updated this revision to Diff 22320.

Closed by commit rPbad7f3d49b38 (authored by @epriestley).

Revision Contents
Changeset List

Diff 22320

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeText.php

Loading...
Phabricator · Built by Phacility