Page MenuHomePhabricator
Differential D9269

Change double quotes to single quotes.
ClosedPublic
Actions

Authored by joshuaspence on May 23 2014, 3:11 PM.
Tags
None
Referenced Files
F14073528: D9269.diff
Thu, Nov 21, 12:55 AM
Unknown Object (File)
Wed, Nov 20, 12:27 PM
Unknown Object (File)
Sun, Nov 10, 5:50 AM
Unknown Object (File)
Wed, Nov 6, 2:03 PM
Unknown Object (File)
Oct 12 2024, 1:55 AM
Unknown Object (File)
Oct 7 2024, 4:51 PM
Unknown Object (File)
Oct 1 2024, 9:17 PM
Unknown Object (File)
Sep 15 2024, 2:01 AM
View All Files
Subscribers
aurelijus
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC17820442da3c: Change double quotes to single quotes.
Summary

Ran arc lint --apply-patches --everything over rARC, mainly to change double quotes to single quotes where appropriate. These changes also validate that the ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE rule is working as expected.

Test Plan

Eyeballed most of the diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22012.May 23 2014, 3:11 PM
joshuaspence retitled this revision from to Change double quotes to single quotes..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 23 2014, 3:11 PM
Herald added subscribers: aurelijus, Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B670: Diff 22012.May 23 2014, 3:12 PM
epriestley accepted this revision.May 23 2014, 8:52 PM
epriestley edited edge metadata.

I skimmed these and didn't catch anything odd looking.

This revision is now accepted and ready to land.May 23 2014, 8:52 PM
epriestley closed this revision.May 23 2014, 8:53 PM
epriestley updated this revision to Diff 22023.

Closed by commit rARC17820442da3c (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
scripts/
6 lines
hgdaemon/
2 lines
2 lines
lib/
2 lines
2 lines
2 lines
src/
configuration/
2 lines
4 lines
6 lines
difference/
__tests__/
18 lines
hgdaemon/
2 lines
6 lines
2 lines
lint/
2 lines
engine/
4 lines
linter/
36 lines
2 lines
8 lines
2 lines
4 lines
16 lines
2 lines
2 lines
24 lines
__tests__/
2 lines
renderer/
4 lines
2 lines
2 lines
2 lines
parser/
6 lines
10 lines
18 lines
__tests__/
4 lines
14 lines
diff/
6 lines
repository/
api/
24 lines
32 lines
8 lines
4 lines
unit/
engine/
18 lines
42 lines
16 lines
34 lines
2 lines
6 lines
34 lines
78 lines
__tests__/
14 lines
4 lines
phutil/
8 lines
renderer/
2 lines
workflow/
10 lines
8 lines
34 lines
4 lines
4 lines
4 lines
12 lines
2 lines
122 lines
6 lines
10 lines
4 lines
4 lines
4 lines
14 lines
8 lines
10 lines
60 lines
30 lines
34 lines
6 lines
46 lines
2 lines
26 lines
18 lines
2 lines
4 lines

Diff 22023

View Options

scripts/arcanist.php

Loading...
View Options

scripts/hgdaemon/hgdaemon_client.php

Loading...
View Options

scripts/hgdaemon/hgdaemon_server.php

Loading...
View Options

scripts/lib/PhutilLibraryMapBuilder.php

Loading...
View Options

scripts/phutil_rebuild_map.php

Loading...
View Options

scripts/phutil_symbols.php

Loading...
View Options

src/configuration/ArcanistConfiguration.php

Loading...
View Options

src/configuration/ArcanistConfigurationManager.php

Loading...
View Options

src/configuration/ArcanistSettings.php

Loading...
View Options

src/difference/__tests__/ArcanistDiffUtilsTestCase.php

Loading...
View Options

src/hgdaemon/ArcanistHgClientChannel.php

Loading...
View Options

src/hgdaemon/ArcanistHgProxyServer.php

Loading...
View Options

src/hgdaemon/ArcanistHgServerChannel.php

Loading...
View Options

src/lint/ArcanistLintPatcher.php

Loading...
View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistCSharpLinter.php

Loading...
View Options

src/lint/linter/ArcanistExternalLinter.php

Loading...
View Options

src/lint/linter/ArcanistFlake8Linter.php

Loading...
View Options

src/lint/linter/ArcanistLinter.php

Loading...
View Options

src/lint/linter/ArcanistPEP8Linter.php

Loading...
View Options

src/lint/linter/ArcanistPyLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistRubyLinter.php

Loading...
View Options

src/lint/linter/ArcanistTextLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php

Loading...
View Options

src/lint/renderer/ArcanistLintConsoleRenderer.php

Loading...
View Options

src/lint/renderer/ArcanistLintJSONRenderer.php

Loading...
View Options

src/lint/renderer/ArcanistLintLikeCompilerRenderer.php

Loading...
View Options

src/lint/renderer/ArcanistLintSummaryRenderer.php

Loading...
View Options

src/parser/ArcanistBaseCommitParser.php

Loading...
View Options

src/parser/ArcanistBundle.php

Loading...
View Options

src/parser/ArcanistDiffParser.php

Loading...
View Options

src/parser/__tests__/ArcanistBundleTestCase.php

Loading...
View Options

src/parser/__tests__/ArcanistDiffParserTestCase.php

Loading...
View Options

src/parser/diff/ArcanistDiffChange.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/repository/api/ArcanistRepositoryAPI.php

Loading...
View Options

src/repository/api/ArcanistSubversionAPI.php

Loading...
View Options

src/unit/engine/ArcanistXUnitTestResultParser.php

Loading...
View Options

src/unit/engine/CSharpToolsTestEngine.php

Loading...
View Options

src/unit/engine/GoTestResultParser.php

Loading...
View Options

src/unit/engine/NoseTestEngine.php

Loading...
View Options

src/unit/engine/PhpunitTestEngine.php

Loading...
View Options

src/unit/engine/PhutilUnitTestEngine.php

Loading...
View Options

src/unit/engine/PytestTestEngine.php

Loading...
View Options

src/unit/engine/XUnitTestEngine.php

Loading...
View Options

src/unit/engine/__tests__/GoTestResultParserTestCase.php

Loading...
View Options

src/unit/engine/__tests__/PhutilUnitTestEngineTestCase.php

Loading...
View Options

src/unit/engine/phutil/ArcanistPhutilTestCase.php

Loading...
View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Loading...
View Options

src/workflow/ArcanistAmendWorkflow.php

Loading...
View Options

src/workflow/ArcanistBackoutWorkflow.php

Loading...
View Options

src/workflow/ArcanistBaseWorkflow.php

Loading...
View Options

src/workflow/ArcanistCallConduitWorkflow.php

Loading...
View Options

src/workflow/ArcanistCloseRevisionWorkflow.php

Loading...
View Options

src/workflow/ArcanistCloseWorkflow.php

Loading...
View Options

src/workflow/ArcanistCommitWorkflow.php

Loading...
View Options

src/workflow/ArcanistCoverWorkflow.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistDownloadWorkflow.php

Loading...
View Options

src/workflow/ArcanistExportWorkflow.php

Loading...
View Options

src/workflow/ArcanistFeatureWorkflow.php

Loading...
View Options

src/workflow/ArcanistFlagWorkflow.php

Loading...
View Options

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

Loading...
View Options

src/workflow/ArcanistHelpWorkflow.php

Loading...
View Options

src/workflow/ArcanistInlinesWorkflow.php

Loading...
View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
View Options

src/workflow/ArcanistLiberateWorkflow.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
View Options

src/workflow/ArcanistPasteWorkflow.php

Loading...
View Options

src/workflow/ArcanistPatchWorkflow.php

Loading...
View Options

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

Loading...
View Options

src/workflow/ArcanistTasksWorkflow.php

Loading...
View Options

src/workflow/ArcanistUnitWorkflow.php

Loading...
View Options

src/workflow/ArcanistUploadWorkflow.php

Loading...
View Options

src/workflow/ArcanistWhichWorkflow.php

Loading...
Phabricator · Built by Phacility