Make `arc shell-complete` more robust.
ClosedPublic
Actions

Authored by joshuaspence on May 23 2014, 2:52 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5122: Running `arc shell-complete` without any arguments throws an error

Commits

rARC85b8b2e5f8ad: Make `arc shell-complete` more robust.

Summary

Fixes T5122. Add some basic error handling to the shell-complete workflow.

Test Plan

arc shell-complete no longer throws errors.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22008.May 23 2014, 2:52 PM

joshuaspence retitled this revision from to Make `arc shell-complete` more robust..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5122: Running `arc shell-complete` without any arguments throws an error.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 23 2014, 2:52 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B668: Diff 22008.May 23 2014, 2:53 PM

epriestley accepted this revision.May 23 2014, 2:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 23 2014, 2:59 PM

Closed by commit rARC85b8b2e5f8ad (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistShellCompleteWorkflow.php

17 lines

Diff 22010

View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Make `arc shell-complete` more robust.ClosedPublicActions