Page MenuHomePhabricator

Don't fatal when viewing a moved document if the target does not exist or isn't visible
ClosedPublic

Authored by epriestley on May 22 2014, 3:10 PM.
Tags
None
Referenced Files
F15409376: D9254.diff
Wed, Mar 19, 4:27 AM
F15395709: D9254.diff
Sun, Mar 16, 9:08 AM
F15378502: D9254.diff
Thu, Mar 13, 2:57 PM
F15334136: D9254.diff
Sat, Mar 8, 7:01 AM
Unknown Object (File)
Sun, Feb 23, 2:22 AM
Unknown Object (File)
Feb 9 2025, 1:08 PM
Unknown Object (File)
Feb 9 2025, 1:08 PM
Unknown Object (File)
Feb 9 2025, 1:08 PM
Subscribers

Details

Summary

Fixes T5156. If a document has been moved but the new one does not exist or can't be seen by the viewer, render a generic message.

Test Plan

Viewed moved-plus-visible and moved-plus-nonvisible documents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't fatal when viewing a moved document if the target does not exist or isn't visible.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phriction/controller/PhrictionDocumentController.php
150

s/contne/content/

This revision is now accepted and ready to land.May 22 2014, 4:42 PM
epriestley updated this revision to Diff 21980.

Closed by commit rP890ae77a9a47 (authored by @epriestley).