Page MenuHomePhabricator

Don't fatal when viewing a moved document if the target does not exist or isn't visible
ClosedPublic

Authored by epriestley on May 22 2014, 3:10 PM.
Tags
None
Referenced Files
F18054607: D9254.id21971.diff
Mon, Aug 4, 6:26 AM
F18051302: D9254.id.diff
Sun, Aug 3, 10:41 PM
F18026636: D9254.diff
Sat, Aug 2, 10:11 PM
Unknown Object (File)
Jun 26 2025, 7:55 PM
Unknown Object (File)
Jun 26 2025, 7:51 PM
Unknown Object (File)
Jun 3 2025, 4:27 PM
Unknown Object (File)
Jun 2 2025, 1:57 AM
Unknown Object (File)
May 26 2025, 10:26 PM
Subscribers

Details

Summary

Fixes T5156. If a document has been moved but the new one does not exist or can't be seen by the viewer, render a generic message.

Test Plan

Viewed moved-plus-visible and moved-plus-nonvisible documents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't fatal when viewing a moved document if the target does not exist or isn't visible.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phriction/controller/PhrictionDocumentController.php
150

s/contne/content/

This revision is now accepted and ready to land.May 22 2014, 4:42 PM
epriestley updated this revision to Diff 21980.

Closed by commit rP890ae77a9a47 (authored by @epriestley).