Page MenuHomePhabricator

Don't fatal when viewing a moved document if the target does not exist or isn't visible
ClosedPublic

Authored by epriestley on May 22 2014, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 10:26 PM
Unknown Object (File)
Sun, May 25, 9:05 AM
Unknown Object (File)
Tue, May 20, 8:03 AM
Unknown Object (File)
Fri, May 9, 11:19 PM
Unknown Object (File)
Apr 28 2025, 5:45 AM
Unknown Object (File)
Apr 22 2025, 9:27 PM
Unknown Object (File)
Apr 21 2025, 12:39 AM
Unknown Object (File)
Apr 20 2025, 8:23 AM
Subscribers

Details

Summary

Fixes T5156. If a document has been moved but the new one does not exist or can't be seen by the viewer, render a generic message.

Test Plan

Viewed moved-plus-visible and moved-plus-nonvisible documents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't fatal when viewing a moved document if the target does not exist or isn't visible.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phriction/controller/PhrictionDocumentController.php
150

s/contne/content/

This revision is now accepted and ready to land.May 22 2014, 4:42 PM
epriestley updated this revision to Diff 21980.

Closed by commit rP890ae77a9a47 (authored by @epriestley).