Use stable commit identifier to load repository commit
ClosedPublic
Actions

Authored by epriestley on May 22 2014, 2:07 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T5113: DiffusionPathChangeQuery fatals if commit fails to load

Commits

Restricted Diffusion Commit
rP38b17157fa96: Use stable commit identifier to load repository commit

Summary

Fixes T5113. This was caught in the crossfire of cleaning up the DiffusionRequest "commit" properties.

Test Plan

Loaded /rXnnnn with some of the nnn missing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21970.May 22 2014, 2:07 AM

epriestley retitled this revision from to Use stable commit identifier to load repository commit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5113: DiffusionPathChangeQuery fatals if commit fails to load.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 22 2014, 2:07 AM

Harbormaster completed remote builds in B647: Diff 21970.May 22 2014, 2:08 AM

btrahan accepted this revision.May 22 2014, 4:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 22 2014, 4:42 PM

Closed by commit rP38b17157fa96 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

2 lines

Diff 21979

View Options

src/applications/diffusion/request/DiffusionRequest.php

Use stable commit identifier to load repository commitClosedPublicActions