Page MenuHomePhabricator

Add an `ArcanistGoLintLinter`.
ClosedPublic

Authored by joshuaspence on May 21 2014, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 5:50 PM
Unknown Object (File)
Tue, Mar 19, 5:50 PM
Unknown Object (File)
Feb 16 2024, 7:23 AM
Unknown Object (File)
Feb 15 2024, 2:34 AM
Unknown Object (File)
Feb 15 2024, 2:34 AM
Unknown Object (File)
Feb 15 2024, 2:34 AM
Unknown Object (File)
Feb 15 2024, 2:34 AM
Unknown Object (File)
Feb 15 2024, 1:49 AM
Subscribers

Details

Summary

Create bindings for golint as an external linter.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add an `ArcanistGoLintLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Diff against the right branch.

epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistGoLintLinter.php
56

This should return false for supportsSeverityConfigurationOrWhateverTheMethodNameIs().

This revision now requires changes to proceed.May 22 2014, 4:11 PM
joshuaspence edited edge metadata.

Return false for canCustomizeLintSeverities.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 23 2014, 2:59 PM
epriestley updated this revision to Diff 22011.

Closed by commit rARC042aa2ee38df (authored by @joshuaspence, committed by @epriestley).