Differential D9235

Allow a limit to be set on the number of results in a query panel
ClosedPublic
Actions

Authored by hach-que on May 21 2014, 7:10 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4980: Move Dashboards to beta

Commits

Restricted Diffusion Commit
rP49c15a6d951c: Allow a limit to be set on the number of results in a query panel

Summary

This allows a maximum number of items to be set in a query panel. Mostly useful when you have a query panel on the feed search and you don't want 4 billion results cluttering your dashboard.

Test Plan

Created a query panel with a maximum and it worked. Left it blank and got the default results.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 21930.May 21 2014, 7:10 AM

hach-que retitled this revision from to Allow a limit to be set on the number of results in a query panel.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T4980: Move Dashboards to beta.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 7:10 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B624: Diff 21930.May 21 2014, 7:12 AM

We should probably default this to, like, 10, too.

This revision is now accepted and ready to land.May 21 2014, 5:09 PM

Closed by commit rP49c15a6d951c (authored by @jamesr, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

paneltype/

PhabricatorDashboardPanelTypeQuery.php

13 lines

Diff 21934

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php

Allow a limit to be set on the number of results in a query panelClosedPublicActions