Add standard spacing around viewing panels
ClosedPublic
Actions

Authored by chad on May 21 2014, 4:21 AM.

Tags

None

Referenced Files

	F13408190: D9232.diff
	Sat, Jul 6, 2:41 AM

	F13399545: D9232.diff
	Thu, Jul 4, 10:27 AM

	F13377103: D9232.diff
	Sat, Jun 29, 3:28 AM

	F13372634: D9232.diff
	Fri, Jun 28, 12:42 PM

	F13349604: D9232.diff
	Sun, Jun 23, 5:10 AM

	F13301568: D9232.id21926.diff
	Sat, Jun 8, 12:17 AM

	F13301567: D9232.id21936.diff
	Sat, Jun 8, 12:17 AM

	F13301566: D9232.id.diff
	Sat, Jun 8, 12:17 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP53940e272f3e: Add standard spacing around viewing panels

Summary

Just wraps them in some boxes in edit and standalone mode.

Test Plan

Tested 3 panels in edit and standalone mode.

Diff Detail

Repository

rP Phabricator

Branch

dash-stage

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 620
Build 620: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21926.May 21 2014, 4:21 AM

chad retitled this revision from to Add standard spacing around viewing panels.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 21 2014, 4:21 AM

Harbormaster completed remote builds in B620: Diff 21926.May 21 2014, 4:22 AM

epriestley accepted this revision.May 21 2014, 5:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 21 2014, 5:07 PM

Closed by commit rP53940e272f3e (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardPanelRenderController.php

6 lines

PhabricatorDashboardPanelViewController.php

7 lines

Diff 21926

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php