Throw when passing array_mergev() non-array items
ClosedPublic
Actions

Authored by epriestley on May 20 2014, 3:33 PM.

Tags

None

Referenced Files

	F14111272: D9213.diff
	Wed, Nov 27, 8:55 PM

	Unknown Object (File)
	Tue, Nov 26, 9:30 AM

	Unknown Object (File)
	Tue, Nov 26, 9:30 AM

	Unknown Object (File)
	Tue, Nov 26, 9:29 AM

	Unknown Object (File)
	Tue, Nov 26, 9:05 AM

	Unknown Object (File)
	Fri, Nov 22, 1:48 AM

	Unknown Object (File)
	Sun, Nov 17, 9:39 PM

	Unknown Object (File)
	Wed, Nov 13, 10:42 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

rPHU195a5f93c043: Throw when passing array_mergev() non-array items

Summary

See rP481a2954545e for an example of the kind of error this can catch.

Test Plan

Ran unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

mergev

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 593
Build 593: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21881.May 20 2014, 3:33 PM

epriestley retitled this revision from to Throw when passing array_mergev() non-array items.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 20 2014, 3:33 PM

Harbormaster completed remote builds in B593: Diff 21881.May 20 2014, 3:34 PM

btrahan accepted this revision.May 20 2014, 4:41 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 20 2014, 4:41 PM

Closed by commit rPHU195a5f93c043 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

19 lines

utils.php

11 lines

Diff 21881

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Throw when passing array_mergev() non-array itemsClosedPublicActions