Page MenuHomePhabricator

Don't hide action lists if there are no property list properties
ClosedPublic

Authored by epriestley on May 19 2014, 5:33 PM.
Tags
None
Referenced Files
F14063404: D9201.diff
Mon, Nov 18, 6:27 PM
F14053353: D9201.diff
Fri, Nov 15, 3:05 PM
F14038238: D9201.diff
Sun, Nov 10, 10:20 PM
F14025120: D9201.diff
Thu, Nov 7, 2:34 PM
F14018669: D9201.diff
Tue, Nov 5, 5:57 PM
F14018541: D9201.id21857.diff
Tue, Nov 5, 2:50 PM
F13989616: D9201.id.diff
Mon, Oct 21, 9:45 PM
F13984671: D9201.id21846.diff
Oct 20 2024, 3:07 PM
Subscribers

Details

Summary

Fixes T5108. If we render a property list with no properties, it doesn't render anything. This hides any attached action list.

Instead, insert an empty property if we have an action list but no properties.

(This could use some cleanup eventually, but resolve the issue for now.)

Test Plan

Viewed a property list with actions but no properties; saw actions.

Diff Detail

Repository
rP Phabricator
Branch
actionlist
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 575
Build 575: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't hide action lists if there are no property list properties.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 7:08 PM
epriestley updated this revision to Diff 21857.

Closed by commit rPedd8242008be (authored by @epriestley).