Page MenuHomePhabricator

Don't hide action lists if there are no property list properties
ClosedPublic

Authored by epriestley on May 19 2014, 5:33 PM.
Tags
None
Referenced Files
F15338239: D9201.diff
Sun, Mar 9, 10:05 AM
Unknown Object (File)
Mon, Mar 3, 4:16 PM
Unknown Object (File)
Mar 1 2025, 4:47 AM
Unknown Object (File)
Feb 12 2025, 2:59 PM
Unknown Object (File)
Feb 4 2025, 4:35 AM
Unknown Object (File)
Jan 29 2025, 7:19 PM
Unknown Object (File)
Jan 28 2025, 1:25 PM
Unknown Object (File)
Jan 27 2025, 4:25 PM
Subscribers

Details

Summary

Fixes T5108. If we render a property list with no properties, it doesn't render anything. This hides any attached action list.

Instead, insert an empty property if we have an action list but no properties.

(This could use some cleanup eventually, but resolve the issue for now.)

Test Plan

Viewed a property list with actions but no properties; saw actions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't hide action lists if there are no property list properties.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 7:08 PM
epriestley updated this revision to Diff 21857.

Closed by commit rPedd8242008be (authored by @epriestley).