Differential D9195

Add a rule to the XHPAST linter to check for whitespace before a semicolon.
ClosedPublic
Actions

Authored by joshuaspence on May 19 2014, 1:49 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCb251615716b3: Add a rule to the XHPAST linter to check for whitespace before a semicolon.

Summary

This rule is based on a rule from PHP_CodeSniffer.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21835.May 19 2014, 1:49 PM

joshuaspence retitled this revision from to Add a rule to the XHPAST linter to check for whitespace before a semicolon..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2014, 1:49 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B568: Diff 21835.May 19 2014, 1:50 PM

The only exception I can think of is that we might have some of this kind of thing:

for (       ; $ii < $limit; $ii++) {

...but that's probably better written as:

for (/* empty */; $ii < $limit; $ii++) {

...or similar.

This revision is now accepted and ready to land.May 19 2014, 2:48 PM

Closed by commit rARCb251615716b3 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

20 lines

__tests__/

xhpast/

semicolon-spacing.lint-test

14 lines

Diff 21840

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/semicolon-spacing.lint-test

Add a rule to the XHPAST linter to check for whitespace before a semicolon.ClosedPublicActions