Page MenuHomePhabricator
Differential D9194

Use PhrictionDocumentQuery to load documents
ClosedPublic
Actions

Authored by epriestley on May 19 2014, 1:43 PM.
Tags
None
Referenced Files
F15475781: D9194.diff
Sun, Apr 6, 11:32 PM
F15427959: D9194.id.diff
Sun, Mar 23, 5:23 PM
F15389765: D9194.id21834.diff
Sat, Mar 15, 5:38 AM
F15379678: D9194.diff
Thu, Mar 13, 10:43 PM
F15341326: D9194.id.diff
Sun, Mar 9, 7:44 PM
Unknown Object (File)
Feb 27 2025, 7:48 AM
Unknown Object (File)
Feb 24 2025, 11:48 AM
Unknown Object (File)
Feb 13 2025, 2:57 PM
View All Files
Subscribers
epriestley
shadowhand

Details

Reviewers
btrahan
Maniphest Tasks
T4029: Support policies on Phriction wiki articles
Commits
Restricted Diffusion Commit
rP4d7c1026f4b3: Use PhrictionDocumentQuery to load documents
Summary

Ref T4029. We use a lot of very outdated content loading in Phriction, which blocks T4029.

Test Plan
  • Called phriction.info
  • Called phriction.history
  • Called phriction.edit
  • Viewed document list.
  • Deleted a document.
  • Viewed history.
  • Viewed a diff.
  • Created a document.
  • Edited a document.
  • Moved a document.
  • Tried to overwrite a document with "new".
  • Tried to overwrite a document with "move".
  • Viewed a moved document note.

Diff Detail

Repository
rP Phabricator
Branch
phriction1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phriction/editor/PhrictionDocumentEditor.php:27XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 567
Build 567: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21834.May 19 2014, 1:43 PM
epriestley retitled this revision from to Use PhrictionContentQuery to load documents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4029: Support policies on Phriction wiki articles.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 19 2014, 1:43 PM
Harbormaster completed remote builds in B567: Diff 21834.May 19 2014, 1:44 PM
shadowhand added a subscriber: shadowhand.May 19 2014, 2:08 PM
epriestley retitled this revision from Use PhrictionContentQuery to load documents to Use PhrictionDocumentQuery to load documents.May 19 2014, 2:33 PM
btrahan accepted this revision.May 19 2014, 6:51 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:51 PM
epriestley closed this revision.May 19 2014, 7:41 PM
epriestley updated this revision to Diff 21860.

Closed by commit rP4d7c1026f4b3 (authored by @epriestley).

Revision Contents
Changeset List

Diff 21834

View Options

src/applications/phriction/conduit/ConduitAPI_phriction_edit_Method.php

Loading...
View Options

src/applications/phriction/conduit/ConduitAPI_phriction_history_Method.php

Loading...
View Options

src/applications/phriction/conduit/ConduitAPI_phriction_info_Method.php

Loading...
View Options

src/applications/phriction/controller/PhrictionController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDeleteController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionEditController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionHistoryController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionMoveController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionNewController.php

Loading...
View Options

src/applications/phriction/editor/PhrictionDocumentEditor.php

Loading...
View Options

src/applications/phriction/phid/PhrictionPHIDTypeDocument.php

Loading...
View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

Loading...
View Options

src/applications/phriction/query/PhrictionSearchEngine.php

Loading...
View Options

src/applications/phriction/search/PhrictionSearchIndexer.php

Loading...
Phabricator · Built by Phacility