Paths

Table of Contentst

Differential D9193

Add a rule to the XHPAST linter for detecting `elseif` usage.
ClosedPublic
Actions

Authored by joshuaspence on May 19 2014, 1:28 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC566c7e9c5cf4: Add a rule to the XHPAST linter for detecting `elseif` usage.

Summary

This rule is adapted from PHP_CodeSniffer and is used to enforce the consistent use of else if.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21832.May 19 2014, 1:28 PM

joshuaspence retitled this revision from to Add a rule to the XHPAST linter for detecting `elseif` usage..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2014, 1:28 PM

Herald added subscribers: neal, Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B566: Diff 21832.May 19 2014, 1:29 PM

epriestley accepted this revision.May 19 2014, 1:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2014, 1:33 PM

Closed by commit rARC566c7e9c5cf4 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

16 lines

__tests__/

xhpast/

elseif.lint-test

19 lines

Diff 21833

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/elseif.lint-test

Add a rule to the XHPAST linter for detecting `elseif` usage.ClosedPublicActions