Page MenuHomePhabricator

Put a cache in front of Celerity transforms, and update packages
ClosedPublic

Authored by epriestley on May 18 2014, 3:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 1:18 PM
Unknown Object (File)
Sun, Sep 22, 11:18 PM
Unknown Object (File)
Aug 31 2024, 12:16 AM
Unknown Object (File)
Aug 29 2024, 3:29 PM
Unknown Object (File)
Aug 27 2024, 11:06 AM
Unknown Object (File)
Aug 25 2024, 1:09 PM
Unknown Object (File)
Aug 25 2024, 12:43 PM
Unknown Object (File)
Aug 25 2024, 12:43 PM
Subscribers

Details

Summary

Fixes T5094. In some cases we do slightly expensive transformations to resources (inlining images, replacing URIs, building packages). We can throw cache in front of them easily since URIs are already permanently associated with a single resource.

Also browse around and move some CSS/JS into packages.

Test Plan

Added logging to verify the caches are working, saw moderately improved performance.

Browsed around looking at resources tab in developer console, saw fewer total requests.

Diff Detail

Repository
rP Phabricator
Branch
ccache
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 542
Build 542: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Put a cache in front of Celerity transforms, and update packages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
resources/celerity/packages.php
4

I just merged these packages since there's no reason to have separate "core" and "javelin" packages.

btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:50 PM
epriestley updated this revision to Diff 21983.

Closed by commit rPf896dc5392a0 (authored by @epriestley).