Page MenuHomePhabricator

Put a cache in front of Celerity transforms, and update packages
ClosedPublic

Authored by epriestley on May 18 2014, 3:46 AM.
Tags
None
Referenced Files
F14063095: D9175.diff
Mon, Nov 18, 4:36 PM
F14052110: D9175.diff
Fri, Nov 15, 6:36 AM
F14037531: D9175.diff
Sun, Nov 10, 4:47 PM
F14023350: D9175.diff
Thu, Nov 7, 1:12 AM
Unknown Object (File)
Oct 13 2024, 3:12 PM
Unknown Object (File)
Oct 7 2024, 10:49 PM
Unknown Object (File)
Oct 5 2024, 5:24 AM
Unknown Object (File)
Oct 5 2024, 3:10 AM
Subscribers

Details

Summary

Fixes T5094. In some cases we do slightly expensive transformations to resources (inlining images, replacing URIs, building packages). We can throw cache in front of them easily since URIs are already permanently associated with a single resource.

Also browse around and move some CSS/JS into packages.

Test Plan

Added logging to verify the caches are working, saw moderately improved performance.

Browsed around looking at resources tab in developer console, saw fewer total requests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Put a cache in front of Celerity transforms, and update packages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
resources/celerity/packages.php
4

I just merged these packages since there's no reason to have separate "core" and "javelin" packages.

btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:50 PM
epriestley updated this revision to Diff 21983.

Closed by commit rPf896dc5392a0 (authored by @epriestley).