Page MenuHomePhabricator

Put a cache in front of Celerity transforms, and update packages
ClosedPublic

Authored by epriestley on May 18 2014, 3:46 AM.
Tags
None
Referenced Files
F13394668: D9175.diff
Wed, Jul 3, 9:06 AM
F13280956: D9175.diff
Jun 2 2024, 9:30 AM
F13272518: D9175.diff
May 30 2024, 3:10 PM
F13242069: D9175.diff
May 23 2024, 1:51 AM
F13241906: D9175.id21794.diff
May 23 2024, 12:12 AM
F13237834: D9175.id21983.diff
May 21 2024, 3:18 PM
F13224875: D9175.id.diff
May 19 2024, 11:34 AM
F13220619: D9175.diff
May 19 2024, 1:49 AM
Subscribers

Details

Summary

Fixes T5094. In some cases we do slightly expensive transformations to resources (inlining images, replacing URIs, building packages). We can throw cache in front of them easily since URIs are already permanently associated with a single resource.

Also browse around and move some CSS/JS into packages.

Test Plan

Added logging to verify the caches are working, saw moderately improved performance.

Browsed around looking at resources tab in developer console, saw fewer total requests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Put a cache in front of Celerity transforms, and update packages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
resources/celerity/packages.php
4

I just merged these packages since there's no reason to have separate "core" and "javelin" packages.

btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:50 PM
epriestley updated this revision to Diff 21983.

Closed by commit rPf896dc5392a0 (authored by @epriestley).