Page MenuHomePhabricator

Adjust action strength of self subscribe/unsubscribe
ClosedPublic

Authored by epriestley on May 17 2014, 9:06 PM.
Tags
None
Referenced Files
F14371795: D9168.diff
Fri, Dec 20, 7:18 PM
Unknown Object (File)
Mon, Dec 9, 5:42 AM
Unknown Object (File)
Wed, Dec 4, 3:29 AM
Unknown Object (File)
Thu, Nov 28, 1:11 PM
Unknown Object (File)
Thu, Nov 28, 1:11 PM
Unknown Object (File)
Thu, Nov 28, 12:19 PM
Unknown Object (File)
Thu, Nov 28, 12:08 PM
Unknown Object (File)
Tue, Nov 26, 10:41 PM
Subscribers

Details

Summary

Ref T4968. If you add a comment to revision you aren't currently subscribed to, the email currently chooses "[Changed Subscribers]" as the action title. This is less interesting than "[Commented]", provided the affected subscriber is you (adding other people is usually interesting).

In this case, reduce the strength of this action below the strength of "comment".

Test Plan

Made several comments in conjunction with implicit and explicit subscriptions. Saw "[Commented]" for stuff affecting me, and "[Changed Subscribers]" for stuff affecting others.

Diff Detail

Repository
rP Phabricator
Branch
substrength
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 533
Build 533: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Adjust action strength of self subscribe/unsubscribe.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Nice!

This revision is now accepted and ready to land.May 19 2014, 6:18 PM
epriestley updated this revision to Diff 21852.

Closed by commit rPdd5d30e643d9 (authored by @epriestley).