Page MenuHomePhabricator

Allow phui-closed-tag to be readable on hover
ClosedPublic

Authored by chad on May 17 2014, 3:52 AM.
Tags
None
Referenced Files
F12842887: D9158.id21764.diff
Thu, Mar 28, 10:22 PM
Unknown Object (File)
Mon, Mar 4, 8:14 PM
Unknown Object (File)
Feb 16 2024, 5:53 AM
Unknown Object (File)
Feb 16 2024, 5:47 AM
Unknown Object (File)
Feb 16 2024, 5:36 AM
Unknown Object (File)
Feb 16 2024, 5:27 AM
Unknown Object (File)
Feb 8 2024, 8:59 AM
Unknown Object (File)
Feb 8 2024, 8:59 AM
Subscribers

Details

Summary

In general these are fairly readable, but if not it cleans up on hover (and hover card).

Test Plan

tested a closed task in my sandbox

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad retitled this revision from to Allow phui-closed-tag to be readable on hover.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

I don't know offhand where to fix the long form remarkup, never worked on remarkup before... is that libphutil?

chad edited edge metadata.
  • add closed state
  • for testing

try this out, we can style the strikethrough here and make it less heavy, as well as remove on hover.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2014, 4:41 AM
chad updated this revision to Diff 21764.

Closed by commit rP697e47459e05 (authored by @chad).