Page MenuHomePhabricator
Differential D9158

Allow phui-closed-tag to be readable on hover
ClosedPublic
Actions

Authored by chad on May 17 2014, 3:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 2:15 PM
Unknown Object (File)
Thu, Dec 19, 10:45 AM
Unknown Object (File)
Tue, Dec 17, 8:21 PM
Unknown Object (File)
Thu, Dec 12, 12:42 AM
Unknown Object (File)
Wed, Dec 11, 7:09 AM
Unknown Object (File)
Mon, Dec 9, 5:22 PM
Unknown Object (File)
Mon, Dec 9, 9:28 AM
Unknown Object (File)
Mon, Dec 9, 3:22 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3510: Indicate a task/revision is closed in Remarkup
Commits
Restricted Diffusion Commit
rP697e47459e05: Allow phui-closed-tag to be readable on hover
Summary

In general these are fairly readable, but if not it cleans up on hover (and hover card).

Test Plan

tested a closed task in my sandbox

Diff Detail

Repository
rP Phabricator
Branch
closed-tag
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 518
Build 518: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21755.May 17 2014, 3:52 AM
chad retitled this revision from to Allow phui-closed-tag to be readable on hover.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 17 2014, 3:52 AM
chad added a comment.May 17 2014, 3:52 AM

I don't know offhand where to fix the long form remarkup, never worked on remarkup before... is that libphutil?

Harbormaster completed remote builds in B517: Diff 21755.May 17 2014, 3:53 AM
epriestley edited edge metadata.May 17 2014, 3:53 AM

You should be able to copy this line:

https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php;31cd9b21698f9adb131d7cda4de09adf337cc29a$59

...and paste it here:

https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php;31cd9b21698f9adb131d7cda4de09adf337cc29a$74-75

...to get strike-by-default.

chad added a comment.May 17 2014, 4:04 AM

(y)

chad updated this revision to Diff 21756.May 17 2014, 4:22 AM
chad edited edge metadata.
  • add closed state
  • for testing
chad added a comment.May 17 2014, 4:22 AM

try this out, we can style the strikethrough here and make it less heavy, as well as remove on hover.

Harbormaster completed remote builds in B518: Diff 21756.May 17 2014, 4:23 AM
chad added a comment.May 17 2014, 4:23 AM

undefined (125×350 px, 12 KB)

epriestley accepted this revision.May 17 2014, 4:41 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2014, 4:41 AM
chad closed this revision.May 17 2014, 4:51 AM
chad updated this revision to Diff 21764.

Closed by commit rP697e47459e05 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
markup/
rule/
2 lines
view/
phui/
13 lines
webroot/
rsrc/
css/
phui/
10 lines

Diff 21756

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
Phabricator · Built by Phacility