Differential D9153
Properly transform Celerity resource URIs with query strings and anchors Authored by epriestley on May 16 2014, 4:24 PM. Tags None Referenced Files
Subscribers
Details
See https://github.com/facebook/phabricator/commit/6a45b7e67091a217a28414cdcc8d02b50875a7d6 These URIs have "?hack=iefix#ieieielol" on them, which the parser doesn't recognize as a known resource, so it errs on the side of caution by not rewriting. Instead, strip this bit off, attempt to rewrite, then put it back on. Loaded font-awesome.css locally and saw properly rewritten URIs.
Diff Detail
Event TimelineComment Actions Specifically, the issue is not rewriting these URIs (in font-awesome.css) correctly: url(/rsrc/externals/font/fontawesome/fontawesome-webfont.eot?v=4.1.0); On many (but not all) configurations, that will still work if we don't rewrite it, but generally works less well than it could/should: it won't get a hash update when it changes, it won't get caching headers added consistently, and won't be able to CDN in the future. |