Paths

Table of Contentst

Differential D9145

Close pholio mocks
ClosedPublic
Actions

Authored by lpriestley on May 15 2014, 9:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 18, 12:03 AM

	Unknown Object (File)
	Thu, Feb 13, 1:32 AM

	Unknown Object (File)
	Mon, Feb 10, 1:48 PM

	Unknown Object (File)
	Sun, Feb 9, 12:57 PM

	Unknown Object (File)
	Sun, Feb 9, 12:57 PM

	Unknown Object (File)
	Sun, Feb 9, 12:56 PM

	Unknown Object (File)
	Sun, Feb 9, 12:56 PM

	Unknown Object (File)
	Sun, Feb 9, 12:56 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4299: Close/remove mocks in Pholio

Commits

Restricted Diffusion Commit
rP3d457a53be60: Close pholio mocks

Summary

Fixes T4299, Add status dropdown to mock edit view

Test Plan

Edit mock, close mock, thumbnail title should read (Disabled). Default mocks list should show only open mocks.

Diff Detail

Repository

Branch

closemocks

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 516
Build 516: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 21714.May 15 2014, 9:40 PM

lpriestley retitled this revision from to Close pholio mocks.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4299: Close/remove mocks in Pholio.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2014, 9:40 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B496: Diff 21714.May 15 2014, 9:41 PM

itsawesome

chad added inline comments.May 15 2014, 9:47 PM

src/applications/pholio/query/PholioMockSearchEngine.php
123	I'm worried if this gets cut off in long titles? Don't recall the CSS offhand.

One inline.

src/applications/pholio/phid/PholioPHIDTypeMock.php
45	This should only be `if ($mock->getStatus() == 'closed')` (or maybe write `$mock->isClosed()` to future-proof this a little).
src/applications/pholio/query/PholioMockSearchEngine.php
123	(We're doing the same thing in Macro right now, the pinboards just don't have a "disabled" style yet.)

This revision now requires changes to proceed.May 15 2014, 9:52 PM

Code review reply

Harbormaster completed remote builds in B516: Diff 21754.May 17 2014, 2:32 AM

Two tiny inlines.

src/applications/pholio/controller/PholioMockViewController.php
70	This can use `isClosed()` now.
src/applications/pholio/query/PholioMockSearchEngine.php
122	As above.

This revision now requires changes to proceed.May 17 2014, 2:34 AM

Using new mock->isClosed()

Harbormaster completed remote builds in B574: Diff 21845.May 19 2014, 4:09 PM

Thanks!

This revision is now accepted and ready to land.May 19 2014, 6:33 PM

Closed by commit rP3d457a53be60 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140514.pholiomockclose.sql

5 lines

src/

applications/

pholio/

constants/

PholioTransactionType.php

1 line

controller/

PholioMockEditController.php

10 lines

PholioMockViewController.php

9 lines

editor/

PholioMockEditor.php

8 lines

phid/

PholioPHIDTypeMock.php

4 lines

query/

PholioMockQuery.php

13 lines

PholioMockSearchEngine.php

35 lines

storage/

12 lines

PholioTransaction.php

13 lines

Diff 21754

resources/sql/autopatches/20140514.pholiomockclose.sql

Loading...

src/applications/pholio/constants/PholioTransactionType.php

Loading...

src/applications/pholio/controller/PholioMockEditController.php

Loading...

src/applications/pholio/controller/PholioMockViewController.php

Loading...

src/applications/pholio/editor/PholioMockEditor.php

Loading...

src/applications/pholio/phid/PholioPHIDTypeMock.php

Loading...

src/applications/pholio/query/PholioMockQuery.php

Loading...

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...

src/applications/pholio/storage/PholioMock.php

Loading...

src/applications/pholio/storage/PholioTransaction.php

Loading...