Page MenuHomePhabricator
Differential D9143

Allow dashboard panels to render in a headerless mode
ClosedPublic
Actions

Authored by epriestley on May 15 2014, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 6:57 PM
Unknown Object (File)
Fri, Oct 25, 6:03 AM
Unknown Object (File)
Oct 19 2024, 5:14 AM
Unknown Object (File)
Oct 19 2024, 5:00 AM
Unknown Object (File)
Oct 19 2024, 4:57 AM
Unknown Object (File)
Oct 16 2024, 10:19 AM
Unknown Object (File)
Oct 2 2024, 1:54 AM
Unknown Object (File)
Sep 23 2024, 5:43 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rP302d5bcec5e7: Allow dashboard panels to render in a headerless mode
Summary

Ref T4986. This mostly just makes tab panels a little nicer.

Maybe this will be modal (header = "none", "edit", "view") in a few diffs but we can clean it up then if so.

Test Plan

Screen_Shot_2014-05-15_at_2.15.35_PM.png (141×862 px, 9 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21712.May 15 2014, 9:18 PM
epriestley retitled this revision from to Allow dashboard panels to render in a headerless mode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2014, 9:18 PM
Harbormaster completed remote builds in B494: Diff 21712.May 15 2014, 9:19 PM
chad accepted this revision.May 15 2014, 9:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 15 2014, 9:20 PM
epriestley closed this revision.May 16 2014, 2:31 AM
epriestley updated this revision to Diff 21730.

Closed by commit rP302d5bcec5e7 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
dashboard/
controller/
3 lines
engine/
47 lines
paneltype/
4 lines
3 lines
webroot/
rsrc/
js/
application/
dashboard/
7 lines

Diff 21730

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...
View Options

webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js

Loading...
Phabricator · Built by Phacility